-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7 gui #8
base: master
Are you sure you want to change the base?
7 gui #8
Conversation
There we go, that was actually pretty straightforward; the GUI was not setting the number of threads the solver should use, and the value was being initialized to |
Qt 6.2 still didn't fully embrace CMake, so had to add extra deploy scripts for that. Runs on Windows now, but extraordinarily slow compared to on Linux. With 12 threads on my 12-core i7-8700, it averages about 1 second per iteration on Ubuntu 24.04. On Windows, it's about 10 seconds per iteration. |
Fixes #7.
This ended up opening several large stinky cans of worms. There were a lot of assumptions in the current code around immediate CLI output that needed changing. Additionally, displaying information in a GUI requires more discrete access to data than the current program allowed. (i.e. no easy way to get the currently assigned probe level).
The end result was perhaps more refactoring than I planned on (or perhaps you wanted...). I had to touch the important bits today (the probe arrangement algorithm) and while it doesn't seem like I broke anything, I wanted to start a PR to get some more eyes.
Big changes
Things still on my to-do list:
One stray observation - while the program will build and run on Windows (VS2022), the simulation does not. I check the current code on Windows, and it freezes on the first iteration as well. I suspect multithreading issues, but haven't poked that hornets nest yet.