Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider banning mechanism #1388

Open
azarovh opened this issue Dec 5, 2023 · 0 comments
Open

Reconsider banning mechanism #1388

azarovh opened this issue Dec 5, 2023 · 0 comments
Labels
p2p p2p related issues

Comments

@azarovh
Copy link
Member

azarovh commented Dec 5, 2023

Having bans in the system has it's own benefits as it quickly reacts and punishes misbehaving nodes thus saves the resources of honest nodes.

On the other hand it is not efficient as banned addresses can be cheaply replaced. Also it can potentially lead to network splits and other negative consequences (such as isolations from Tor network and de-anonymisation).
See chapter V-F in https://ieeexplore.ieee.org/stamp/stamp.jsp?arnumber=9877811 for Tor related problems.

Since PR 14929 and later PR 19219 bitcoin doesn't ban peer but utilises discouragement. At the moment we can't afford this approach as it implies abundance in nodes.

@azarovh azarovh added the p2p p2p related issues label Dec 5, 2023
@ImplOfAnImpl ImplOfAnImpl mentioned this issue Dec 8, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2p p2p related issues
Projects
None yet
Development

No branches or pull requests

1 participant