Fix ConnectTransactionError::MissingTransactionNonce
#1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azarovh
force-pushed
the
fix/missing_tx_nonce
branch
from
a4c4e9a to
c386d32
Compare
Comment on lines
+442
to
444
| // When deleting a delegation nonce value is preserved in the db | ||
| // in case reorg happens so we don't have to restore it | ||
| Some( |
There was a problem hiding this comment.
Please make sure we're not doing anything else like this. We should only delete such information in a pruned database after the max reorg depth.
There was a problem hiding this comment.
Please make sure we're not doing anything else like this.
I'd merge this and then I'll go thought the code and see what tests I can add.
We should only delete such information in a pruned database after the max reorg depth.
we don't do this yet
There was a problem hiding this comment.
I know we don't do it. But I mean that such deletions shouldn't happen unless we do it.
I don't think you need a fork. This isn't a validation rule. |
TheQuantumPhysicist
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we spend from delegation we increment nonces: 1 -> 2 -> 3
When we undo such txs we decrement nonces.
But if we spend the delegation entirely and the pool is decommissioned we delete nonce from db: 1->2->3->None
Now if we want to undo that last transaction we need to read the nonce and decrement it, but it’s not in the db because we deleted it.
The simplest solution would be to not delete nonces from the db.