Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error notification label a11y #420

Open
ppvg opened this issue Nov 28, 2023 · 1 comment
Open

Error notification label a11y #420

ppvg opened this issue Nov 28, 2023 · 1 comment
Labels
a11y Accessibility fixes and improvements Non core set Outside the base set of components Notifications Component 'Notifications'
Milestone

Comments

@ppvg
Copy link
Member

ppvg commented Nov 28, 2023

From independent accessibility report, SC 1.3.2:

Op pagina components/notification-error.html staan voorbeelden van foutmeldingen. Bij het blokelement staat de tekst "Foutmelding:" boven de kop. Dit is een probleem, omdat hiermee in de code niet duidelijk is dat deze tekst bij deze kop hoort. Zorg er daarom bijvoorbeeld voor dat deze tekst onderdeel van de kop wordt of onder de kop komt te staan. Visueel mag de volgorde dan hetzelfde blijven.

The error notification div example in the docs has a heading. This means that, if an AT user navigates by headings, the <span>Error:</span> is skipped and it may be unclear that this is an error message. This can be solved by putting the "Error:" inside the heading or moving the span below the heading in the markup.

@ppvg ppvg added the a11y Accessibility fixes and improvements label Nov 28, 2023
@ppvg
Copy link
Member Author

ppvg commented Nov 28, 2023

Side note: moving the span below the heading may complicate the CSS selectors for styling the span.

As an alternative solution, we could look into perhaps leaving the span where it is, and using aria-describedby on the div to point at the span. Since the div has role=group, that might result in AT providing that context when jumping directly to the heading (requires verification).

Additionally: the aria-label on the div should probably be removed.

@HeleenSG HeleenSG added the Notifications Component 'Notifications' label Sep 19, 2024
@Davidemeer Davidemeer added the Non core set Outside the base set of components label Sep 30, 2024
@Davidemeer Davidemeer added this to the Fase 2 Manon milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility fixes and improvements Non core set Outside the base set of components Notifications Component 'Notifications'
Projects
None yet
Development

No branches or pull requests

3 participants