feat: sortable table #391
Merged
feat: sortable table #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underdarknl
reviewed
Oct 10, 2023
Co-authored-by: Rick Lambrechts <[email protected]>
ppvg
force-pushed
the
feat/sortable-table
branch
from
bdc08b1
to
79f4759
Compare
|
I have tested it and found that it is also good to add |
HeleenSG
approved these changes
Jul 25, 2024
That's a good point! I don't think it's necessary to add it to the example HTML as it's context-dependent whether it's needed, but we can add it to the instructions. We'll go over these again soon so I'll leave it for now. |
jpbruinsslot
added a commit
that referenced
this pull request
Aug 5, 2024
* main: (70 commits) chore(deps-dev): bump prettier-plugin-svelte from 3.2.5 to 3.2.6 (#602) chore(deps-dev): bump vite from 5.3.3 to 5.3.4 (#601) chore: update table-sortable in icore_open_docs to match main docs (#605) feat: sortable table (#391) feat: iCore open theme, header navigation button (#604) fix: Adds link state styling iCore open theme (#603) ci: fix github-pages workflow (#600) fix: breadcrumb base path (#599) chore: update pnpm to v9 (#590) chore(deps-dev): bump prettier from 3.3.2 to 3.3.3 (#592) chore(deps-dev): bump rimraf from 5.0.8 to 6.0.1 (#594) fix: remove source code comment from docs Code component (#598) chore(deps-dev): bump stylelint from 16.3.1 to 16.7.0 (#595) chore(deps-dev): bump sass from 1.77.6 to 1.77.8 (#596) fix: remove broken links from icore docs (#589) chore(deps): bump highlight.js from 11.9.0 to 11.10.0 (#593) fix: Adds bold font reference (#588) fix: icore-open font-faces (#591) chore(deps-dev): bump svelte from 4.2.12 to 4.2.18 (#577) chore(deps-dev): bump vite from 5.2.11 to 5.3.3 (#576) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes an improved sortable table and implements an interactive example. N.B.: the example implementation is purely demonstrative and not meant to be used by consumers of Manon, as sortable data is quite context-sensitive.
The approach in this PR turns out to match up with the ARIA APG Sortable Table Example.
Things yet to consider and possibly address in the docs:
margin-leftto the<th>button to ensure its text aligns with table cell text.aria-liveregion to announce e.g. "table sorted bycolumnascending/descending".I've published an interactive demo of this approach here: https://sortable-table-demo.netlify.app/.