[pull] main from elastic:main #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
## Summary Assign test files to security solution team Contributes to: #192979 --------- Co-authored-by: Elastic Machine <[email protected]>
## Summary We've had some questions around legacy migrations that are flagged as deprecated in the type. This updates the typescript doc comment to hopefully clarify that.
…201785) Closes #169196 ## Summary - The columns 'created at', 'updated at', 'closed at', 'severity', and 'external incident' were missing the 'width' property, resulting in a display issue where these columns appeared squeezed on screen resolutions below 1450px. - To address this, the 'width' properties for these columns have been added and adjusted to ensure proper display https://github.com/user-attachments/assets/b5d6735e-49b8-4b35-9648-a1ea1b30e1ef
## Summary Make the configuration for Connectors a copyable codeblock during create a connector flow.
## Summary Resolves #193352 Documented the usage of `bump_agent_policy_revision` and using `revision` to bump on agent policy SO changes. I think it's not needed to introduce `bump_agent_policy_revision` on the agent policy SO type, enough to bump revision, and the agent policy will be deployed on Fleet setup when https://github.com/elastic/kibana/blob/main/x-pack/plugins/fleet/server/services/agent_policies/deploy_agent_policies_task.ts is running. --------- Co-authored-by: Cristina Amico <[email protected]>
… obs-ai-assistant,security-solution (#201165) This PR migrates test suites that use `renderHook` from the library `@testing-library/react-hooks` to adopt the equivalent and replacement of `renderHook` from the export that is now available from `@testing-library/react`. This work is required for the planned migration to react18. ## Context In this PR, usages of `waitForNextUpdate` that previously could have been destructured from `renderHook` are now been replaced with `waitFor` exported from `@testing-library/react`, furthermore `waitFor` that would also have been destructured from the same renderHook result is now been replaced with `waitFor` from the export of `@testing-library/react`. ***Why is `waitFor` a sufficient enough replacement for `waitForNextUpdate`, and better for testing values subject to async computations?*** WaitFor will retry the provided callback if an error is returned, till the configured timeout elapses. By default the retry interval is `50ms` with a timeout value of `1000ms` that effectively translates to at least 20 retries for assertions placed within waitFor. See https://testing-library.com/docs/dom-testing-library/api-async/#waitfor for more information. This however means that for person's writing tests, said person has to be explicit about expectations that describe the internal state of the hook being tested. This implies checking for instance when a react query hook is being rendered, there's an assertion that said hook isn't loading anymore. In this PR you'd notice that this pattern has been adopted, with most existing assertions following an invocation of `waitForNextUpdate` being placed within a `waitFor` invocation. In some cases the replacement is simply a `waitFor(() => new Promise((resolve) => resolve(null)))` (many thanks to @kapral18, for point out exactly why this works), where this suffices the assertions that follow aren't placed within a waitFor so this PR doesn't get larger than it needs to be. It's also worth pointing out this PR might also contain changes to test and application code to improve said existing test. ### What to do next? 1. Review the changes in this PR. 2. If you think the changes are correct, approve the PR. ## Any questions? If you have any questions or need help with this PR, please leave comments in this PR. Co-authored-by: Elastic Machine <[email protected]>
…ding (#202126) ## Summary Closes #194460 Fixed the logic that calculates if agent is stuck in updating. Agents shouldn't be considered stuck in updating if they are in `UPG_SCHEDULED` or any other upgrade state apart from `UPG_FAILED`. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
## Summary Add implementation of create, update, and fetch methods for the `SecurityWorkflowInsightsService`. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Konrad Szwarc <[email protected]>
## Summary Assign test files to obs team Contributes to: #192979
…g page (#201411) ## Summary part of elastic/security-team#10667 Added support for multiple topics to the onboarding hub. Including: - Added group buttons to the header to select the Topic. It appears only if more than one topic is available. - Topics are configurable and can have required license, and capabilities, just like cards. - Added required experimental flags property to topic and card configurations. - Implemented selected topic persistence in the URL and localStorage, extending the existing feature for the selected card. - Siem migrations topic implemented with only connectors card (more cards will come later) - Connectors card shared components extracted to _common/connectors_ > [!NOTE] > This feature needs `siemMigrationsEnabled` experimental flag enabled to work. Otherwise only the default topic will be available and the topic selector won't be displayed. https://github.com/user-attachments/assets/1ec54911-71b9-4001-aeb4-a30564a83ca7 --------- Co-authored-by: Elastic Machine <[email protected]>
## Summary Resolves [#1292](elastic/kibana-team#1292) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
## Summary Fixes #201829 This PR fixes a regression introduced with #178965 where specific visualization display options were ignored in the embeddable context. Additional tests have been added to avoid further regressions in the future. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
## Summary Couple of changes to support Elastic-managed connectors in 9.x ### Video overview https://github.com/user-attachments/assets/086ae96a-0520-483e-b055-5e672b3f65f5 ### List of changes 1. Elatic-managed connectors now enforce `content-` prefix <img width="400" alt="Screenshot 2024-11-28 at 14 55 27" src="https://github.com/user-attachments/assets/aa7f6d6d-39af-42ad-b5f1-5455e37006df"> 2. Banner about not attached index changed to warning (yellow) instead of danger (red) - as this is not an error state <img width="400" alt="Screenshot 2024-11-28 at 14 54 48" src="https://github.com/user-attachments/assets/00d5c332-0366-4420-8934-32404b4fb1c3"> 3. Get rid of native connector API keys from UI - as they won't work anyway without ent-search node <img width="400" alt="Screenshot 2024-11-28 at 14 56 22" src="https://github.com/user-attachments/assets/6fcea6b4-0559-4419-83d6-4a9db9a71c88"> 4. Index name generation for native connectors, `content-` is always added as prefix for native <img width="400" alt="Screenshot 2024-11-28 at 14 57 01" src="https://github.com/user-attachments/assets/c17ccc35-1d91-4666-8db5-b796685c928e"> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]>
## Summary Handles #191998 Follow up work: - elastic/security-team#11112 - #196667 This PR add below entity flyouts for below entities in One Discover: - host.name - user.name - source.ip - destination.ip In this PR we re-use the security solution code by making use of below model based on `discover-shared` plugin. ```mermaid flowchart TD discoverShared["Discover Shared"] securitySolution["Security Solution"] discover["Discover"] securitySolution -- "registers Features" --> discoverShared discover -- "consume Features" --> discoverShared ``` ## How to Test >[!Note] >This PR adds `security-root-profile` in One discover which is currently in `experimental mode`. All changes below can only be tested when profile is activated. Profile can activated by adding below lines in `config/kibana.dev.yml` > ```yaml > discover.experimental.enabledProfiles: > - security-root-profile > ``` > 1. As mentioned above, adding above experimental flag in `kibana.dev.yml`. 2. Spin up Security Serverless project and add some alert Data. 3. Navigate to Discover and add columns `host.name` and `user.name` in table. Now `host` and `user` flyouts should be available on clicking `host.name`, `user.name`, `source.ip` & `destination.ip`. 4. Flyout should work without any error. 5. Below things are not working and will be tackled in followup PR : - Security Hover actions - Actions such as `Add to Timeline` or `Add to Case` ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )