Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pump custom metrics default value #124

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Ambarish07
Copy link
Collaborator

Description

Prometheus custom metrics giving error when custom tags are introduced as part of custom metric labels.
Example : We had a usecase where we need a custom metrics where a custom Label should also be coming as part of prometheus custom metric. But if the custom label is not defined then the pump gives an error.
Solution : added a default value "UNKNOWN" of all the custom labels.

Related Issue

How This Has Been Tested

Tested in local by recreating tyk in local by adding custom metric.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). If pulling from your own
    fork, don't request your master!
  • Make sure you are making a pull request against the master branch (left side). Also, you should start
    your branch off our latest master.
  • My change requires a change to the documentation.
    • If you've changed APIs, describe what needs to be updated in the documentation.
  • I have updated the documentation accordingly.
  • Modules and vendor dependencies have been updated; run go mod tidy && go mod vendor
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Check your code additions will not fail linting checks:
    • go fmt -s
    • go vet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants