From aa524cbcdb94a78f62e4e943b7ec348edf5df167 Mon Sep 17 00:00:00 2001 From: ArthurW Date: Thu, 10 Oct 2024 14:52:50 +0200 Subject: [PATCH] Rename Irmin.Node.S.effect type to read_effect --- CHANGES.md | 5 +++++ src/irmin/node_intf.ml | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index ffa53a7bf1..3c24bf10d9 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -5,6 +5,11 @@ - **irmin-git** - Expose `Content_addressable` type (#2329, @art-w) +### Changed + +- **irmin** + - Rename `Node.S.effect` to `read_effect` for OCaml 5.3 compatibility (#2347, @art-w) + ### Fixed - **irmin-client** diff --git a/src/irmin/node_intf.ml b/src/irmin/node_intf.ml index 9d9fda43a1..2fae339997 100644 --- a/src/irmin/node_intf.ml +++ b/src/irmin/node_intf.ml @@ -124,10 +124,10 @@ module type Core = sig purpose (so [Tree.hash] and [Tree.equal] are not in the Lwt monad as well). *) - type effect := expected_depth:int -> node_key -> t option + type read_effect := expected_depth:int -> node_key -> t option (** The type for read effects. *) - val with_handler : (effect -> effect) -> t -> t + val with_handler : (read_effect -> read_effect) -> t -> t (** [with_handler f] replace the current effect handler [h] by [f h]. [f h] will be called for all the recursive read effects that are required by recursive operations on nodes. .*)