Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pct_encoder interface is confusing #159

Open
leviroth opened this issue Sep 3, 2021 · 0 comments
Open

pct_encoder interface is confusing #159

leviroth opened this issue Sep 3, 2021 · 0 comments

Comments

@leviroth
Copy link

leviroth commented Sep 3, 2021

There are a few things I found confusing about the interface for constructing pct_encoders:

  1. val pct_encoder takes a bunch of arguments whose names are the names of components and whose types are also components. I think it's clear enough what pct_encoder ~query_key:(`Custom (...)) () means, but what would be meant by pct_encoder ~query_key:`Scheme? Likewise, it's hard to understand what the component in `Custom (component, _, _) means.

  2. In the `Custom case, it's not clear what happens when a char is marked both safe and unsafe, or when it is omitted from either set.

I have some hunches from skimming the implementation, but it would be nice to have the answers be more clear in the interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant