-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README updates and bug fix for Flask starter escaped quotes #188
README updates and bug fix for Flask starter escaped quotes #188
Conversation
…tes for Flask starter, add yaml file for Connect Firebase app.
@bishopwm is attempting to deploy a commit to the miro-web Team on Vercel. A member of the Team first needs to authorize it. |
Hi @bishopwm - I've just tried this and all works fine. Great work! The one thing I would say is too call out that the dev needs to check the box for "expire auth token" when they create an app, otherwise the app won't work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left one suggestion - I think you should be able to directly apply it.
Basically the app won't work unless you expire user auth token @bishopwm
- You have the latest versions of Flask and Python installed. | ||
|
||
# 🏃🏽♂️ Run the app locally <a name="run"></a> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch @horeaporutiu !
Just updated it with this 👍
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
||
0. Create a new Miro App and make sure to check the box for `Expire user authorization token` as shown in the screenshot below. | ||
|
||
> ⚠️ If you don't check this box, the app will not work! ⚠️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why (in 1 sentence)?
Updated README for Flask Python Starter with OAuth, fix bug with escaped quotes in Flask templates, add a yaml file to Connect Firebase example.