Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README updates and bug fix for Flask starter escaped quotes #188

Merged
merged 5 commits into from
Sep 11, 2023

Conversation

bishopwm
Copy link
Contributor

@bishopwm bishopwm commented Sep 7, 2023

Updated README for Flask Python Starter with OAuth, fix bug with escaped quotes in Flask templates, add a yaml file to Connect Firebase example.

@bishopwm bishopwm requested a review from a team as a code owner September 7, 2023 11:27
@vercel
Copy link

vercel bot commented Sep 7, 2023

@bishopwm is attempting to deploy a commit to the miro-web Team on Vercel.

A member of the Team first needs to authorize it.

@horeaporutiu
Copy link
Contributor

Hi @bishopwm - I've just tried this and all works fine. Great work!

The one thing I would say is too call out that the dev needs to check the box for "expire auth token" when they create an app, otherwise the app won't work.

Copy link
Contributor

@horeaporutiu horeaporutiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left one suggestion - I think you should be able to directly apply it.

Basically the app won't work unless you expire user auth token @bishopwm

- You have the latest versions of Flask and Python installed.

# 🏃🏽‍♂️ Run the app locally <a name="run"></a>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Create a new Miro App and make sure to check the box for Expire user authorization token as shown in the screenshot below.

⚠️ If you don't check this box, the app will not work! ⚠️

expire-auth-token

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @horeaporutiu !

Just updated it with this 👍

@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-examples-wordle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2023 2:36pm


0. Create a new Miro App and make sure to check the box for `Expire user authorization token` as shown in the screenshot below.

> ⚠️ If you don't check this box, the app will not work! ⚠️
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why (in 1 sentence)?

@bishopwm bishopwm merged commit ad89ca1 into miroapp:main Sep 11, 2023
2 checks passed
@bishopwm bishopwm deleted the will-readme-updates-bugfix-python branch September 11, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants