Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX-2411 Add a warning about expiring cookies #193

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

kirillsud
Copy link
Collaborator

No description provided.

@kirillsud kirillsud requested a review from a team as a code owner September 14, 2023 09:39
@vercel
Copy link

vercel bot commented Sep 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-examples-wordle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 11:01am
webhooks-manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 11:01am

@@ -60,6 +60,12 @@ Once your server is up and running:
2. Open a board in your Developer team.
3. To start the app, click the corresponding app icon in the app toolbar on the left.

> ⚠️ In case of error `401` returned by a REST API request, remove the `miro_tokens` cookie for the `localhsot`
> domain in the browser.
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add either a screenshot / explanation of how to do that? I'm still not sure myself, so I think some devs maybe will not how to remove cookies for localhost specifically.

*typo in localhsot

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it

Chrome -> Settings -> Privacy and Security -> Clear browsing data? I think this is not right.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it depends on the browser. For example, we can add a screenshot for Chrome's DevTools:

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually one small typo for localhost in line 63 @kirillsud

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-09-14 at 13 31 38

What is a bit strange is I dont have any cookies for localhost and I still see the 401 error

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry please ignore now I do see them

@@ -60,6 +60,12 @@ Once your server is up and running:
2. Open a board in your Developer team.
3. To start the app, click the corresponding app icon in the app toolbar on the left.

> ⚠️ In case of error `401` returned by a REST API request, remove the `miro_tokens` cookie for the `localhsot`
> domain in the browser.
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me!

@kirillsud kirillsud merged commit 352b440 into main Sep 18, 2023
2 checks passed
@kirillsud kirillsud deleted the DX-2411-fix-webcam-example branch September 18, 2023 11:14
@mettin
Copy link
Contributor

mettin commented Sep 18, 2023

Should we have this in create-react-app too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants