-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opt out of React-Router v4 #51
Comments
I've done some experimenting with opting out of React Router in Mirror on this project branch. It's not complete, and may not be necessary. I see a few options now for dealing with the router:
Both 2 & 3 would create breaking changes, though easy to fix. |
I would recommend |
I think think a submodule makes the most sense. Also the same design of dva/router. Dva also recently created multiple different router packages with the 2.0.1 release, including "dva/no-router". I think this is a bit much, as its not really necessary to load another package if you're not using the router. |
There should be a way to opt out of using react-router v4.
This would be especially useful for mobile. Currently, Mirror is not compatible with "react-native" due to the dependency on
react-dom
. Opting intoreact-router-native
isn't much better, as it's not currently the most popular routing option.As a suggestion, using dynamic imports, would make it possible to opt out of using the router.
The text was updated successfully, but these errors were encountered: