feat: Improved variable handling for config #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows an environment variable in any position for headers as long
as it is in format `$VAR` or `${VAR}` allowing alphanumeric characters
and underscore `_`. This is now also applied to `remote_schema_url` in
addition to headers.
Fixes mirumee#328
Relates to mirumee#231
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows an environment variable in any position for headers as long as it is in format
$VARor${VAR}allowing alphanumeric characters and underscore_. This is now also applied toremote_schema_urlin addition to headers.Fixes #328
Relates to #231
I don't know if this is desired given what was said in #231 but the fix felt easy enough and I don't see much risk of pulling in
resince it's a one time pass of the config which would be minimal compared to the rest where time is spent. Also didn't feel it added much more complexity.