Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with MPF 0.57 #20

Open
ericselk2018 opened this issue Dec 29, 2023 · 2 comments
Open

Does not work with MPF 0.57 #20

ericselk2018 opened this issue Dec 29, 2023 · 2 comments

Comments

@ericselk2018
Copy link

This file:

https://github.com/missionpinball/mpf-ls/blob/dev/mpfls/workspace.py

References this file:

https://github.com/missionpinball/mpf/blob/0.56.x/mpf/file_interfaces/yaml_roundtrip.py

Which was removed as of 0.57.

Also, the readme install should probably have "pip install mpf-language-server" as the example install command, since all of the MPF docs have been switched back to using pip and not pipx, and also running LS in a venv comes with other issues like vscode not being able to find it, so probably best to install globally (at least for novice users following default instructions).

@PretenshusGourd
Copy link

This file:

https://github.com/missionpinball/mpf-ls/blob/dev/mpfls/workspace.py

References this file:

https://github.com/missionpinball/mpf/blob/0.56.x/mpf/file_interfaces/yaml_roundtrip.py

Which was removed as of 0.57.

Also, the readme install should probably have "pip install mpf-language-server" as the example install command, since all of the MPF docs have been switched back to using pip and not pipx, and also running LS in a venv comes with other issues like vscode not being able to find it, so probably best to install globally (at least for novice users following default instructions).

did you find a way around this?

@gbouthenot
Copy link

Use the mpf-057 branch : https://github.com/missionpinball/mpf-ls/tree/mpf-0.57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants