Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Notifications #13454

Closed
1 task
tassoman opened this issue Feb 24, 2024 · 2 comments
Closed
1 task

Broken Notifications #13454

tassoman opened this issue Feb 24, 2024 · 2 comments
Labels
⚠️bug? This might be a bug

Comments

@tassoman
Copy link
Contributor

tassoman commented Feb 24, 2024

💡 Summary

immagine

🥰 Expected Behavior

as administrator I would be informed of defective user profiles

🤬 Actual Behavior

Notification TL is empty. Browser's console error: "TypeError: e is undefined".
I filtered notification types, then I discovered first result is missing userId object.

[
  {
    "id": "9q2bnq6nn6",
    "createdAt": "2024-02-23T14:38:52.751Z",
    "type": "follow",
    "userId": "9q2biearmp"
  },
  {
    "id": "9pvk1k514g",
    "createdAt": "2024-02-18T20:59:11.797Z",
    "type": "follow",
    "userId": "97x0dxh5xn",
    "user": {
      "id": "97x0dxh5xn",
     ...................
      "onlineStatus": "unknown"
    }
  }
]

📝 Steps to Reproduce

  1. install misskey 2024-02-0
  2. view follow notification, filtered
  3. have a following notification, without userId data

💻 Frontend Environment

* Misskey: 2024-02-0

🛰 Backend Environment (for server admin)

* Installation Method or Hosting Service: docker build master
* Misskey: 2024.02.0

Do you want to address this bug yourself?

  • Yes, I will patch the bug myself and send a pull request
@tassoman tassoman added the ⚠️bug? This might be a bug label Feb 24, 2024
@tassoman
Copy link
Contributor Author

tassoman commented Feb 24, 2024

This happened: I've deleted spam accounts and a particular not wanted local account.
Maybe happened: misskey had deleted everything about that account, except follow notification, who maybe left orphan by userId.

@1Step621
Copy link
Contributor

Duplicate of #13369, #13430
Wip on #13284 (#13412)

@tamaina tamaina closed this as not planned Won't fix, can't repro, duplicate, stale Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️bug? This might be a bug
Projects
None yet
Development

No branches or pull requests

3 participants