Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MkReactionViewerで❤️が押せない #13459

Closed
tamaina opened this issue Feb 26, 2024 · 9 comments
Closed

MkReactionViewerで❤️が押せない #13459

tamaina opened this issue Feb 26, 2024 · 9 comments
Labels
🐛Bug Unexpected behavior 🔥high priority packages/frontend Client side specific issue/PR
Milestone

Comments

@tamaina
Copy link
Contributor

tamaina commented Feb 26, 2024

バックエンドは❤=\u2764に正規化するがフロントエンドは❤️=\u2764\ufe0fのみをユニコード絵文字として認識するため、MkReactionViewerで❤️が押せない(カスタム絵文字扱い?になる

@tamaina tamaina added 🐛Bug Unexpected behavior packages/frontend Client side specific issue/PR labels Feb 26, 2024
@tamaina
Copy link
Contributor Author

tamaina commented Feb 26, 2024

#13298 (comment)

@tamaina
Copy link
Contributor Author

tamaina commented Feb 29, 2024

ぐえ

@tamaina
Copy link
Contributor Author

tamaina commented Feb 29, 2024

これはリリース前に直すべき

@mei23
Copy link
Contributor

mei23 commented Feb 29, 2024

なんか["♟️", "chess_pawn", 4],とかも押せないわね

@mei23
Copy link
Contributor

mei23 commented Feb 29, 2024

(カスタム絵文字扱い?になる

クライアント側の判定ロジックどうなってるのかしらね

@tamaina
Copy link
Contributor Author

tamaina commented Feb 29, 2024

Fixed by 7565f7b

(多分)

@tamaina tamaina closed this as completed Feb 29, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in [BUG TRACKER] Frontend Feb 29, 2024
@mei23
Copy link
Contributor

mei23 commented Feb 29, 2024

const canToggle = computed(() => {
return !props.reaction.match(/@\w/) && $i && emoji.value && checkReactionPermissions($i, props.note, emoji.value);
});

がundefinedになるわね

@tamaina
Copy link
Contributor Author

tamaina commented Feb 29, 2024

const canToggle = computed(() => {
return !props.reaction.match(/@\w/) && $i && emoji.value && checkReactionPermissions($i, props.note, emoji.value);
});

がundefinedになるわね

7565f7b が?

@mei23
Copy link
Contributor

mei23 commented Feb 29, 2024

7565f7b
でなおったわね

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Unexpected behavior 🔥high priority packages/frontend Client side specific issue/PR
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants