Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): 広告が同一ドメインの場合はRouterで遷移するように #13510

Merged
merged 6 commits into from
Mar 7, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

What

Why

Fix #13481

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.68%. Comparing base (08d618b) to head (74b0298).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13510       +/-   ##
============================================
+ Coverage    64.69%   77.68%   +12.98%     
============================================
  Files          986      185      -801     
  Lines       110809    25038    -85771     
  Branches      5692      484     -5208     
============================================
- Hits         71691    19451    -52240     
+ Misses       37682     5580    -32102     
+ Partials      1436        7     -1429     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

Changelogを入れたところが違うのでautomated releaseのあれを発動するなりしないといけない

@kakkokari-gtyih
Copy link
Contributor Author

c解消

@syuilo syuilo merged commit c680e35 into misskey-dev:develop Mar 7, 2024
@syuilo
Copy link
Member

syuilo commented Mar 7, 2024

🙏

@kakkokari-gtyih kakkokari-gtyih deleted the enh-13481 branch March 7, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

広告がMisskeyと同一ドメインの場合はRouterで遷移する
2 participants