fix(frontend): ノート投稿に関する実績が投稿したアカウントで解除されるように #13511
Open
+38
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13511 +/- ##
============================================
- Coverage 39.47% 19.16% -20.32%
============================================
Files 1559 726 -833
Lines 196948 103499 -93449
Branches 3563 996 -2567
============================================
- Hits 77750 19833 -57917
+ Misses 118592 83111 -35481
+ Partials 606 555 -51 ☔ View full report in Codecov by Sentry. |
kakkokari-gtyih
commented
Mar 4, 2024
Comment on lines
500
to
501
| // バックエンドにも実績を獲ったかどうかのチェックがあるのでtoken指定時は常に実績獲得を送信する | ||
| if (!token && claimedAchievements.includes(type)) return; |
There was a problem hiding this comment.
自アカウントの場合は獲得されたかどうかがすぐに分かるけどtoken指定の場合はそうは行かないので、token指定時は実績がすでに獲得されているかどうかの判定を行わずすべて送信する仕様にした（バックエンド側でも獲得されているかのチェックが入るので問題なさそう）
There was a problem hiding this comment.
Suggested change
| // バックエンドにも実績を獲ったかどうかのチェックがあるのでtoken指定時は常に実績獲得を送信する | |
| if (!token && claimedAchievements.includes(type)) return; | |
| // バックエンドにも実績を獲ったかどうかのチェックがあるのでtoken指定時は常に実績獲得を送信する | |
| if ((!token || token === $i.token) && claimedAchievements.includes(type)) return; |
でもいいかもしれない
|
Changelogを入れたところが違うのでautomated releaseのあれを発動するなりしないといけない |
|
ｃ解消 |
|
解消 |
syuilo
reviewed
Mar 30, 2024
Comment on lines
+492
to
+495
| const claimingQueue = new Set<{ | ||
| name: typeof ACHIEVEMENT_TYPES[number]; | ||
| token?: string; | ||
| }>(); |
There was a problem hiding this comment.
SetにObject入れても期待した結果にならないわね(別のものとして扱われる)
There was a problem hiding this comment.
別アカウントの実績だけ即時獲得にするか
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Fix #13361
Additional info (optional)
Checklist