Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(backend): ページ、ギャラリー、Playのモデレーション強化 #13523

Merged

Conversation

zyoshoka
Copy link
Contributor

@zyoshoka zyoshoka commented Mar 5, 2024

What

以下のことを行いました。

  • 不適切な Page、ギャラリー、Play を管理者権限で削除できるように
  • 不適切な Page、ギャラリー、Play を通報できるように
  • Page、ギャラリー、Play ページの UI 修正

Why

Closes #10280
Closes #10565
Closes #13469

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js labels Mar 5, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -38157,6 +38157,15 @@
                       }
                     }
                   },
+                  "ACCESS_DENIED": {
+                    "value": {
+                      "error": {
+                        "message": "Access denied.",
+                        "code": "ACCESS_DENIED",
+                        "id": "c86e09de-1c48-43ac-a435-1c7e42ed4496"
+                      }
+                    }
+                  },
                   "INVALID_PARAM": {
                     "value": {
                       "error": {

Get diff files from Workflow Page

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 13.80597% with 231 lines in your changes missing coverage. Please review.

Project coverage is 41.71%. Comparing base (b68b2ee) to head (687f42b).
Report is 24 commits behind head on develop.

Files Patch % Lines
packages/frontend/src/pages/page.vue 0.00% 68 Missing ⚠️
packages/frontend/src/pages/gallery/post.vue 0.00% 49 Missing ⚠️
packages/frontend/src/pages/flash/flash.vue 0.00% 48 Missing ⚠️
...d/src/server/api/endpoints/gallery/posts/delete.ts 30.00% 21 Missing ⚠️
...s/backend/src/server/api/endpoints/flash/delete.ts 13.63% 19 Missing ⚠️
...s/backend/src/server/api/endpoints/pages/delete.ts 13.63% 19 Missing ⚠️
...ackages/frontend/src/pages/admin/modlog.ModLog.vue 0.00% 6 Missing ⚠️
...es/frontend/src/components/MkAbuseReportWindow.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13523      +/-   ##
===========================================
+ Coverage    38.88%   41.71%   +2.82%     
===========================================
  Files         1545     1551       +6     
  Lines       190505   196888    +6383     
  Branches      3262     2721     -541     
===========================================
+ Hits         74087    82129    +8042     
+ Misses      115857   114197    -1660     
- Partials       561      562       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor

ページとPlayのデザインだいぶ変えちゃったので修正必要かも🙏

@zyoshoka zyoshoka changed the title enhance(backend): Page、ギャラリー、Playのモデレーション強化 enhance(backend): ページ、ギャラリー、Playのモデレーション強化 Jun 1, 2024
@zyoshoka zyoshoka force-pushed the enhance-page-gallery-flash-moderation branch from 449dcc7 to 7948311 Compare June 1, 2024 08:26
@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented Jun 23, 2024

👀

@syuilo syuilo merged commit fd744f4 into misskey-dev:develop Aug 17, 2024
28 of 30 checks passed
@syuilo
Copy link
Member

syuilo commented Aug 17, 2024

👍🏻

@zyoshoka zyoshoka deleted the enhance-page-gallery-flash-moderation branch August 17, 2024 06:58
kakkokari-gtyih added a commit to kakkokari-gtyih/misskey that referenced this pull request Aug 17, 2024
LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Aug 19, 2024
* enhance(backend): Page、ギャラリー、Playのモデレーション強化

* Update CHANGELOG.md

* fix: update misskey-js

* refactor(frontend): use `MkA`

* Update CHANGELOG.md

* fix(i18n): Page -> ページ
LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
None yet
3 participants