fix: 設定とコンパネでPageMetadataが切り替わらない問題など (taiyme/misskey#186) #13530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13530 +/- ##
===========================================
+ Coverage 77.90% 77.93% +0.02%
===========================================
Files 185 185
Lines 25504 25531 +27
Branches 487 487
===========================================
+ Hits 19870 19897 +27
Misses 5627 5627
Partials 7 7 ☔ View full report in Codecov by Sentry. |
1 task
|
/preview |
tai-cha
approved these changes
Mar 6, 2024
| }); | ||
|
|
||
| const cleanups: (() => void)[] = []; | ||
| const cleanup = () => { | ||
| for (const cl of cleanups) cl(); |
There was a problem hiding this comment.
要素数が少ないので大きな差はないし特にコーディングルールがある認識でもないので好みの問題かもしれないですが
Suggested change
| for (const cl of cleanups) cl(); | |
| cleanups.forEach(cl => cl()); |
There was a problem hiding this comment.
個人的にはforEachで回す方が好みですが、既にfor...ofで実装されているコードがあったので、そちらに合わせました
|
draft外しました！ |
taiyme
commented
Mar 6, 2024
Comment on lines
+367
to
+372
| @supports (height: 100cqh) { | ||
| height: 100cqh; | ||
| overflow: hidden; // fallback (overflow: clip) | ||
| overflow: clip; | ||
| contain: strict; | ||
| } |
There was a problem hiding this comment.
自分のforkの都合でCSSのフォールバックを含んでいますが、misskey-dev/misskeyの方針では不要でしょうか？
There was a problem hiding this comment.
これのフォールバックは入っていなかったはず
taiyme
commented
Mar 6, 2024
Comment on lines
362
to
+372
| height: 100%; | ||
| margin: 0 auto; | ||
| display: flex; | ||
| box-sizing: border-box; | ||
|
|
||
| @supports (height: 100cqh) { | ||
| height: 100cqh; | ||
| overflow: hidden; // fallback (overflow: clip) | ||
| overflow: clip; | ||
| contain: strict; | ||
| } |
There was a problem hiding this comment.
フォールバックが不要であれば
Suggested change
| height: 100%; | |
| margin: 0 auto; | |
| display: flex; | |
| box-sizing: border-box; | |
| @supports (height: 100cqh) { | |
| height: 100cqh; | |
| overflow: hidden; // fallback (overflow: clip) | |
| overflow: clip; | |
| contain: strict; | |
| } | |
| height: 100cqh; | |
| overflow: clip; | |
| contain: strict; | |
| margin: 0 auto; | |
| display: flex; | |
| box-sizing: border-box; |
|
/preview |
|
スクロールの扱い的に、クラシックUIで都合が悪そう |
|
コンフリクト解消 |
|
/preview |
|
コンフリクト解消 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
resolve #13450
ただし、以下の問題について根本的な修正は実施していません。
(いずれ別のPRで。 #12836 (comment) の実装を待ちたい)
Additional info (optional)
Cherry-picked from taiyme/misskey
Note:
admin/_header_.vueを削除し、MkPageHeaderに置き換えましたadmin/_header_.vueで使用していたheaderActionsのasFullButtonオプションをMkPageHeaderで実装しましたChecklist