fix(frontend): 通知が重複して受信される問題を修正 #13531
Open
+31
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 5739f5e)
kakkokari-gtyih
commented
Mar 6, 2024
Comment on lines
+93
to
+99
| if (!connection) { | ||
| connection = useStream().useChannel('main'); | ||
| if (connection) { | ||
| connection.on('notification', onNotification); | ||
| connection.on('notificationFlushed', reload); | ||
| } | ||
| } |
There was a problem hiding this comment.
deactivatedされた後に通信が復活しないのもなんかアレな気がしたのでこれは型定義を良さそうな感じにした上で復活した
There was a problem hiding this comment.
connectionの詳細な仕様をよくわかってないので必要無い説はある
Comment on lines
+60
to
70
| function onNotification(notification: Misskey.entities.Notification) { | ||
| const isMuted = props.excludeTypes ? props.excludeTypes.includes(notification.type) : false; | ||
| const isAlreadyShown = pagingComponent.value?.items.has(notification.id); | ||
| if (isMuted || document.visibilityState === 'visible') { | ||
| useStream().send('readNotification'); | ||
| } | ||
|
|
||
| if (!isMuted) { | ||
| if (!isMuted && !isAlreadyShown) { | ||
| pagingComponent.value?.prepend(notification); | ||
| } | ||
| } |
There was a problem hiding this comment.
その上でUIに流すかどうかをリアルタイム受信時に確認させるようにした
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #13531 +/- ##
============================================
+ Coverage 64.69% 77.67% +12.97%
============================================
Files 986 185 -801
Lines 110809 25028 -85781
Branches 5692 484 -5208
============================================
- Hits 71691 19441 -52250
+ Misses 37682 5580 -32102
+ Partials 1436 7 -1429 ☔ View full report in Codecov by Sentry. |
|
これコネクションを捨てるんではなく単にリスナーを外すだけにしたほうか良いやつ？ |
syuilo
reviewed
Mar 6, 2024
| connection = useStream().useChannel('main'); | ||
| connection.on('notification', onNotification); | ||
| connection.on('notificationFlushed', reload); | ||
| if (!connection) { |
There was a problem hiding this comment.
Suggested change
| if (!connection) { | |
| if (connection == null) { |
| }); | ||
|
|
||
| onActivated(() => { | ||
| if (!connection) { |
There was a problem hiding this comment.
Suggested change
| if (!connection) { | |
| if (connection == null) { |
| connection.on('notificationFlushed', reload); | ||
| if (!connection) { | ||
| connection = useStream().useChannel('main'); | ||
| if (connection) { |
| }); | ||
|
|
||
| onActivated(() => { | ||
| if (!connection) { | ||
| connection = useStream().useChannel('main'); | ||
| if (connection) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Partially cherry-picked from MisskeyIO#504
Why
Fix #13517
治るかはわからない
Additional info (optional)
Checklist