-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(frontend): リアクションの総数を表示するように #13532
Conversation
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -75638,6 +75638,9 @@
]
}
},
+ "reactionCount": {
+ "type": "number"
+ },
"renoteCount": {
"type": "number"
},
@@ -75676,6 +75679,7 @@
"reactionAcceptance",
"reactionEmojis",
"reactions",
+ "reactionCount",
"renoteCount",
"repliesCount"
] |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13532 +/- ##
===========================================
+ Coverage 64.69% 66.07% +1.37%
===========================================
Files 986 989 +3
Lines 110809 115383 +4574
Branches 5692 5723 +31
===========================================
+ Hits 71691 76234 +4543
- Misses 37682 37715 +33
+ Partials 1436 1434 -2 ☔ View full report in Codecov by Sentry. |
リアクションの総数ってクライアントからは取れなかったっけ |
計算したら出せるとはおもう(APIでは取れなかったはず) |
<i v-if="appearNote.reactionAcceptance === 'likeOnly' && appearNote.myReaction != null" class="ti ti-heart-filled" style="color: var(--eventReactionHeart);"></i> | ||
<i v-else-if="appearNote.myReaction != null" class="ti ti-minus" style="color: var(--eventReaction);"></i> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
色はaccentで統一する方が良さそう
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ハートが緑になるのはおかしいのでそっちはそのままでいい気がする
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ハートはそのまま、リアクション選択時の色はaccentにした
#13212 はrelatedだけど解決できるものではなさそう(閲覧するユーザー側でリアクション数だけを表示したいという要望なはず) |
👍🏻 |
What
reactionCount
が生えましたWhy
#13212
Additional info (optional)
Checklist