enhance: 人気のユーザー一覧の降順にpvを使えるように #14196
Draft
+192
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ミスった |
github-actions
bot
added
packages/frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #14196 +/- ##
============================================
+ Coverage 19.54% 99.40% +79.85%
============================================
Files 713 4 -709
Lines 100312 5709 -94603
Branches 997 69 -928
============================================
- Hits 19610 5675 -13935
+ Misses 80158 34 -80124
+ Partials 544 0 -544 ☔ View full report in Codecov by Sentry. |
|
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -555,6 +555,14 @@
"string",
"null"
]
+ },
+ "preferPopularUserFactor": {
+ "type": "string",
+ "enum": [
+ "follower",
+ "pv",
+ "none"
+ ]
}
},
"required": [
@@ -663,7 +671,8 @@
"urlPreviewMaximumContentLength",
"urlPreviewRequireContentLength",
"urlPreviewUserAgent",
- "urlPreviewSummaryProxyUrl"
+ "urlPreviewSummaryProxyUrl",
+ "preferPopularUserFactor"
]
}
}
@@ -13911,6 +13920,14 @@
"string",
"null"
]
+ },
+ "preferPopularUserFactor": {
+ "type": "string",
+ "enum": [
+ "follower",
+ "pv",
+ "none"
+ ]
}
}
}
@@ -67519,7 +67536,9 @@
"+createdAt",
"-createdAt",
"+updatedAt",
- "-updatedAt"
+ "-updatedAt",
+ "+pv",
+ "-pv"
]
},
"state": {
@@ -81087,6 +81106,14 @@
"enableUrlPreview": {
"type": "boolean"
},
+ "preferPopularUserFactor": {
+ "type": "string",
+ "enum": [
+ "follower",
+ "pv",
+ "none"
+ ]
+ },
"backgroundImageUrl": {
"type": [
"string",
@@ -81186,6 +81213,7 @@
"translatorAvailable",
"mediaProxy",
"enableUrlPreview",
+ "preferPopularUserFactor",
"backgroundImageUrl",
"impressumUrl",
"logoImageUrl", |
kakkokari-gtyih
commented
Jul 14, 2024
|
PVが人気度の指標として適当なのか良く分からんわね |
サーバーの規模が大きいなら、人気のユーザーセクションに載る人が固定されてしまうのを避けながら注目しているユーザーを表示できると思う サーバー内の人数が少なかったりするとpvはアテにならない可能性があるのでフォロワー数のほうが人気量を表すのに適しているかもしれないけど、サーバーの規模が大きいとフォロワー数が大きい人が固定されてしまうのでそれはそれでどうなのという話 |
|
人気ユーザーのページをオフにできるのちょっと嬉しい |
nenohi
reviewed
Aug 22, 2024
Comment on lines
75
to
80
| const chartUsers: { userId: string; count: number; }[] = []; | ||
| if (ps.sort?.endsWith('pv')) { | ||
| await this.perUserPvChart.getChartUsers('day', 0, null, ps.limit, ps.offset).then(users => { | ||
| chartUsers.push(...users); | ||
| }); | ||
| } |
There was a problem hiding this comment.
これ作っておいてあれだけど多分ミスってる気がする
同じユーザーしか返さないので一旦待ってもらえると（どっかのタイミングで修正します
There was a problem hiding this comment.
MisskeyIO#728 をちぇりぴしたので解消したかも？
(cherry picked from commit c82bf75)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
(Cherry-picked from io)
Why
Fix #14194
Additional info (optional)
Checklist