Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): 検索ページのホスト指定とユーザー指定を統合 #14780

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Oct 19, 2024

What

image

  • fix/tweak(frontend): 検索ページでユーザー名が長い場合はみ出る問題
  • enh: ホスト指定とユーザー指定を統合

Why

  • ユーザー指定するとローカル指定/サーバー指定が使えないので最初から分けるようにしたほうが自然

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Oct 19, 2024
@kakkokari-gtyih kakkokari-gtyih changed the title Enh tweak search page enhance(frontend): 検索ページのホスト指定とユーザー指定を統合 Oct 19, 2024
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 222 lines in your changes missing coverage. Please review.

Project coverage is 19.13%. Comparing base (224bbd4) to head (a9c8a95).

Files with missing lines Patch % Lines
packages/frontend/src/pages/search.note.vue 0.00% 215 Missing ⚠️
packages/frontend/src/pages/search.user.vue 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14780       +/-   ##
============================================
- Coverage    39.47%   19.13%   -20.34%     
============================================
  Files         1559      725      -834     
  Lines       196944   103560    -93384     
  Branches      3616      995     -2621     
============================================
- Hits         77747    19820    -57927     
+ Misses      118591    83186    -35405     
+ Partials       606      554       -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review October 19, 2024 08:35
@kakkokari-gtyih
Copy link
Contributor Author

こfぬりくと解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

@kakkokari-gtyih
Copy link
Contributor Author

コンフリクト解消

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

2 participants