Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

新しい実績を追加 #11817

Merged
merged 6 commits into from
Sep 12, 2023

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Sep 11, 2023

What

  • 通知テストボタンを連打した際に実績 smashTestNotificationButton を解除
    image

    • 300ms以内の間隔で10回以上通知をテストしたら発火
  • Changelogの「通知テスト」に関する項を、ClientからGeneralに移した
    (いらなければ戻します / 戻してください)

Why

Resolve #11816

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR labels Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (f9fc743) 78.94% compared to head (9980a68) 78.93%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11817      +/-   ##
===========================================
- Coverage    78.94%   78.93%   -0.01%     
===========================================
  Files          925      749     -176     
  Lines        97501    74570   -22931     
  Branches      7744     7232     -512     
===========================================
- Hits         76970    58865   -18105     
+ Misses       20531    15705    -4826     
Files Changed Coverage Δ
packages/backend/src/core/AchievementService.ts 81.60% <100.00%> (+0.14%) ⬆️

... and 177 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member

syuilo commented Sep 12, 2023

ちょっと調整した

@syuilo syuilo merged commit 3456680 into misskey-dev:develop Sep 12, 2023
9 checks passed
@syuilo
Copy link
Member

syuilo commented Sep 12, 2023

🙏🏻

@kakkokari-gtyih kakkokari-gtyih deleted the notif-test-achievement branch September 12, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

通知テストを連打したときに実績解除
2 participants