Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 特定ロールポリシーによる運営アクティビティの検知範囲拡大に対応 #14974

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

samunohito
Copy link
Member

What

運営アクティビティの検知範囲は「rootユーザであること」「モデレータ以上の権限を有するロールにアサインされていること」に限られていましたが、非モデレータロールでも特定のポリシーを有するロールにアサインされていればアクティビティの検知対象とするようにしました。
デフォルト値はfalseなので、明示的に有効化しない限りは機能しません。

Why

#13437 の対応

Additional info (optional)

  • UnitTestを作成して確認
  • 対象ポリシーを持つ非モデレータロールを用意し、実際にジョブを動かして招待制に切り替わることを確認

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js packages/backend:test labels Nov 16, 2024
Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 71.55963% with 31 lines in your changes missing coverage. Please review.

Project coverage is 41.58%. Comparing base (a3d236c) to head (326401c).
Report is 448 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/pages/admin/roles.editor.vue 0.00% 21 Missing ⚠️
packages/frontend/src/pages/admin/roles.vue 0.00% 8 Missing ⚠️
...cessors/CheckModeratorsActivityProcessorService.ts 95.34% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14974      +/-   ##
===========================================
- Coverage    41.74%   41.58%   -0.17%     
===========================================
  Files         1549     1567      +18     
  Lines       196555   203620    +7065     
  Branches      2767     3728     +961     
===========================================
+ Hits         82055    84673    +2618     
- Misses      113939   118340    +4401     
- Partials       561      607      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

github-actions bot commented Nov 16, 2024

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -81820,6 +81820,9 @@
           },
           "canImportUserLists": {
             "type": "boolean"
+          },
+          "isModeratorInactivityCheckTarget": {
+            "type": "boolean"
           }
         },
         "required": [
@@ -81853,7 +81856,8 @@
           "canImportBlocking",
           "canImportFollowing",
           "canImportMuting",
-          "canImportUserLists"
+          "canImportUserLists",
+          "isModeratorInactivityCheckTarget"
         ]
       },
       "ReversiGameLite": {

Get diff files from Workflow Page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend:test packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant