Feature/boot output #281
Open
Feature/boot output #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is intressting to see how many cycle the other CPU's have to wait before they will be initialized.
Ensure kernel boot message is consistently spaced from other output
qhuo
reviewed
Oct 20, 2024
| @@ -10,12 +10,13 @@ volatile static int started = 0; | |||
| void | |||
| main() | |||
| { | |||
| // Initialize an array to hold a waitcycle count per cpu. | |||
| uint waitcycle[NCPU]; | |||
There was a problem hiding this comment.
Do we need this to be an array?
Since, if I understand it correctly, main() is run by every cpu core independently, each with its own stack. If we put waitcycle on the stack, there is no need for this to be an array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel boot output is a bit more verbose with this changes.