Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change when running a clean npm install because of angular version #16

Open
claudemuller opened this issue Feb 19, 2017 · 0 comments

Comments

@claudemuller
Copy link
Collaborator

I removed the old node_modules (with my pending pull request) and reinstalled them again both on Windows as well as Linux. The app then breaks i.e. the http module has a breaking change (Angular when from 1.5.7 to 1.6.2). In the newer version it is implemented with a promise and requires the use of a .then() instead of .success() and .error(). This causes the app to stop loading when it reaches line 41 in controllers/base.js, which then stops Angular from loading and shows the last element in the DOM tree - the delete confirmation dialog.

I have fixed this in another commit and as soon as the pending pull request gets resolved, I can create another for this fix.

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant