From a6317e60b06519d3c00a2c0621701f3da0837a88 Mon Sep 17 00:00:00 2001 From: Flarnie Marchan Date: Tue, 13 Feb 2018 13:02:22 -0800 Subject: [PATCH] Widen logging and add stack trace for IE selection bug Summary: We are hoping to remove this flag that was meant to fix an IE selection bug. It blocks selection events from being handled while React is rendering - the thing is, this has never been a problem that we can see. We are logging to see if real users actually hit this bug and if the flag prevents a bad state in that case. If we find that the flag is never hit, then it will soon be removed, unlocking removal of a deprecated lifecycle method. Reviewed By: sophiebits Differential Revision: D6971850 fbshipit-source-id: 8874b21161de3b3f0f568baca2a8c0278b01fa54 --- src/component/handlers/edit/editOnSelect.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/component/handlers/edit/editOnSelect.js b/src/component/handlers/edit/editOnSelect.js index 21c59c4910..bce9279589 100644 --- a/src/component/handlers/edit/editOnSelect.js +++ b/src/component/handlers/edit/editOnSelect.js @@ -33,7 +33,7 @@ function editOnSelect(editor: DraftEditor): void { DraftJsDebugLogging.logBlockedSelectionEvent({ // For now I don't think we need any other info anonymizedDom: 'N/A', - extraParams: '', + extraParams: JSON.stringify({stacktrace: new Error().stack}), selectionState: JSON.stringify(selectionState.toJS()), }); }