Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookie Domain Not Copied #162

Open
mkueng1 opened this issue Mar 23, 2019 · 1 comment
Open

Cookie Domain Not Copied #162

mkueng1 opened this issue Mar 23, 2019 · 1 comment
Labels
enhancement

Comments

@mkueng1
Copy link

mkueng1 commented Mar 23, 2019 •
edited
Loading

In ProxyServlet.copyProxyCookie() there's a comment

don't set cookie domain

Why is that? In my case I need this.
Would you agree to have a parameter to enable copying the domain? Of course it only makes sense when the domain is part of the used host.
@dsmiley
Copy link
Collaborator

dsmiley commented Mar 4, 2020

I worked on this a long time ago but, yeah, I figured the domain isn't necessarily the same host so it's unsafe to set the host. Feel free to propose a PR.

@Shounaks Shounaks mentioned this issue May 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsmiley @mkueng1