Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'tar' filter when extracting tarfiles #707

Merged

Conversation

ddalcino
Copy link
Contributor

Fix #700.

This is to address a Snyk warning. The new code will only run on Python 3.11.4 and above.

Tested locally with Python 3.11.2 and 3.11.5. Although we can't see it in the code coverage with a single version of Python, I can confirm personally that both arms of the conditional are being entered.

This is to address a SNYK warning. The new code will only run on Python
3.11.4 and above
@miurahr miurahr merged commit ea12c61 into miurahr:master Aug 28, 2023
56 of 58 checks passed
@ddalcino ddalcino deleted the topic/ddalcino/cli/tarfile-extraction-filter branch August 28, 2023 12:18
@ddalcino
Copy link
Contributor Author

Oops; looks like this change caused this failure on Windows: https://github.com/miurahr/aqtinstall/actions/runs/5997958636/job/16265345067

On that CI runner, it looks like Python 3.10 is installed, and the test is not expecting to see the warning Extracting may be unsafe; consider updating Python to 3.11.4 or greater. Let me fix that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

potential security issue in tar extraction
2 participants