fix(mjml-core): proper validation of mjml tag #2709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRyusa
reviewed
Sep 11, 2023
Comment on lines
+1
to
+11
| import { BodyComponent } from 'mjml-core' | ||
|
|
||
| export default class MjDocument extends BodyComponent { | ||
| static componentName = 'mjml' | ||
|
|
||
| static endingTag = false | ||
|
|
||
| render() { | ||
| return '' | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not really happy with this solution here, body component expect to render something, it's just a hack at the end to make it work :/
I guess we could add something like a "mock-class" inside MJML just here to list mjml attributes + dependencies but it doesn't really need to have it's own package and should live inside mjml-core
|
Closing for now we won't go in this direction I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2695
So, the dependency rules were not working correctly because
<mjml>tag was entirely ignored. Without it MJML wasn't working, so I made new component that represents the<mjml>tag , so dependency rules can work properly. It can encapsulate document, for example it can be used to generate skeleton code here in render instead of special behavior for that, but it needs more refactoring then.Couldn't find place in package to write tests so here is proof of validity:
https://github.com/mjmlio/mjml/assets/32848266/39905889-2f15-4500-b405-4edd02e91110