Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MJML dependency version #13

Open
arokanto opened this issue Sep 7, 2020 · 3 comments
Open

Bump MJML dependency version #13

arokanto opened this issue Sep 7, 2020 · 3 comments

Comments

@arokanto
Copy link

arokanto commented Sep 7, 2020

This package still relies on mjml version ^3.2.2. When installing you get the following warnings:

warning mjml2json > mjml > mjml-cli > [email protected]: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies.
warning mjml2json > mjml > mjml-cli > chokidar > [email protected]: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
warning mjml2json > mjml > mjml-button > react > fbjs > [email protected]: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.

Maybe the mjml dependency should be bumped to something on the 4.x line.

@arokanto
Copy link
Author

arokanto commented Mar 3, 2021

Any news on this? mjmj 3.2 has 279 low-severity vulnerabilities. All of them are because of outdated versions of node-fetch and ini, which are required by transitive dependencies of mjml 3.2.

Do you have plans to update this module to require mjml 4? For me mjml2json is still a useful module.

@stianjensen
Copy link

I tried looking at this, but there are quite a few breaking changes and not all seem to be documented, so it requires some work looking into the internals of mjml: #25

@istr
Copy link

istr commented Dec 20, 2023

I provided #29 that works and replaces #25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants