Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant cast in generated code #177

Open
rpost opened this issue Dec 19, 2023 · 1 comment · May be fixed by #180
Open

Redundant cast in generated code #177

rpost opened this issue Dec 19, 2023 · 1 comment · May be fixed by #180

Comments

@rpost
Copy link

rpost commented Dec 19, 2023

Generated builders contain constructor which in turn contains cast which javac (sometimes?) treats as redundant and complains about that with warning.

Sample from my project:

DebitMandateBuilder.java:27: warning: [cast] redundant cast to DebitMandateBuilder
    self = (DebitMandateBuilder)this;
           ^
error: warnings found and -Werror specified
1 error
1 warning

We have strict warning policy (javac -Werror flag) and this means compilation fails.

Please resolve this warning.
rpost added a commit to rpost/pojobuilder that referenced this issue Dec 19, 2023
@rpost
Fix mkarneim#177 - Suppress warnings in generated builder constructor
651ecb7
@rpost rpost mentioned this issue Dec 19, 2023
Closed
@jahlbornG
Copy link

hey, was hoping to use this library, but we ran into this error as well. any info on when this might be fixed?

rpost added a commit to rpost/pojobuilder that referenced this issue Apr 11, 2024
@rpost
Fix mkarneim#177 - Suppress warnings in generated builder constructor
d69447b
rpost added a commit to rpost/pojobuilder that referenced this issue Apr 11, 2024
@rpost
Fix mkarneim#177 - Suppress warnings in generated builder constructor
bda99e7
@rpost rpost linked a pull request Apr 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rpost @jahlbornG