Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmnet: support stable kernels with netdevice::dev_addr changes #230

Open
wants to merge 1 commit into
base: workstation-12.5.9
Choose a base branch
from

Conversation

Ionic
Copy link

@Ionic Ionic commented Nov 22, 2023

Stable backported 48eab831ae8b ("net: create netdev->dev_addr assignment helpers") to the 4.19, 5.4 and 5.10 series, so we need to skip our compat helpers for high enough patch levels.

(Also, sorry for all the PR spam, but there seems to be no better way to get that included. I wish there were a way to create one PR for multiple branches...)

Stable backported 48eab831ae8b ("net: create netdev->dev_addr assignment
helpers") to the 4.19, 5.4 and 5.10 series, so we need to skip our
compat helpers for high enough patch levels.
@Ionic
Copy link
Author

Ionic commented Nov 22, 2023

Actually, can you do me a favor and cherry-pick this commit to the following non-retarded branches:

  • workstation-14.1.7
  • workstation-15.5.7
  • workstation-16.2.5
  • player-12.5.9
  • player-14.1.7
  • player-15.5.7
  • player-16.2.5

I've tested that it cherry-picks well to the aforementioned branches. 17.{0,5} don't need it.

@mkubecek
Copy link
Owner

Thank you for catching this but I'll check first if there really isn't a sane(r) way to detect the backport, this would be so ugly that I would like to make sure it's the only option.

@Ionic
Copy link
Author

Ionic commented Nov 22, 2023

I haven't seen any other way. I'm aware that this adds a few magic numbers (the patch levels), but there really doesn't seem to be a different way to detect that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants