Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Benchmark" into "Task" (for disambiguation) #589

Open
d-uzlov opened this issue Oct 25, 2022 · 1 comment
Open

Rename "Benchmark" into "Task" (for disambiguation) #589

d-uzlov opened this issue Oct 25, 2022 · 1 comment
Assignees
Labels
priority:low type:refactoring No functional changes needed but code quality/readability is affected

Comments

@d-uzlov
Copy link
Contributor

d-uzlov commented Oct 25, 2022

Currently we use the word "benchmark" for both individual benchmarks of one model, and for the benchmark suite, or the app as a whole.
It would be easier to understand if we rename individual benchmarks to "tasks".
We already use this name in some places.

@anhappdev anhappdev self-assigned this Nov 20, 2022
@anhappdev
Copy link
Collaborator

We can either rename benchmark -> task or task -> benchmark since the 2 terms are used interchangeable here.
Actually, renaming task -> benchmark would be easier since it does not impact the backend code (all the backend settings currently use the term benchmark_setting and benchmark_id)

@anhappdev anhappdev added priority:low type:refactoring No functional changes needed but code quality/readability is affected labels Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low type:refactoring No functional changes needed but code quality/readability is affected
Projects
None yet
Development

No branches or pull requests

2 participants