Make Metrics optional to support Ruby only development, update README.md with Prometheus info (DBAI-55)
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssciolla
commented
Jun 3, 2024
Comment on lines
+50
to
+57
|
|
||
| Deployed versions of this application also use [Prometheus](https://prometheus.io/), | ||
| and an associated Push Gateway, to publish and collect metrics about runs. | ||
| During local development, you can use the `prometheus` and `pushgateway` Docker services | ||
| to experiment with this functionality. | ||
|
|
||
| The following sections will assume you are not using a database -- or Prometheus -- | ||
| with Ruby outside a container. |
There was a problem hiding this comment.
@jayamala17, do you think we should add anything else about Prometheus and metrics to the README? I was wondering if a new dedicated section was appropriate. I have a shaky grasp of how it works now, but if there's anything else that I or other devs would need to know, we could add something.
There was a problem hiding this comment.
This can be a separate issue I suppose.
jayamala17
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve DBAI-55.