Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shap as optional dependency #275

Open
mmschlk opened this issue Nov 13, 2024 · 1 comment
Open

Remove shap as optional dependency #275

mmschlk opened this issue Nov 13, 2024 · 1 comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request

Comments

@mmschlk
Copy link
Owner

mmschlk commented Nov 13, 2024

Currently shap is used as a dependency for creating some of the plots in shapiq. Keeping shap as an optional dependency makes updating shapiq to newer Python versions and allowing shapiq to work with newer numpy versions quite stressful and tricky.

I think removing shap as imports anywhere in the project could be a good idea. For this we would need to re-create the plots in our own version. This could be more or less effort.

@mmschlk mmschlk added enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 13, 2024
@mmschlk mmschlk moved this to 💡Idea in shapiq development Nov 13, 2024
@hbaniecki
Copy link
Collaborator

Good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
Status: 💡Idea
Development

No branches or pull requests

2 participants