Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Doc Versioning #369

Closed
sappelhoff opened this issue Mar 22, 2020 · 4 comments
Closed

MAINT: Doc Versioning #369

sappelhoff opened this issue Mar 22, 2020 · 4 comments

Comments

@sappelhoff
Copy link
Member

sappelhoff commented Mar 22, 2020

With #364 #366 and #367 I started towards having versioned docs: It's true that we probably could do without them at this point, but I think it's nice to have.

This is my plan:

  1. get MRG: MAINT/0.1 --> fixes to build old docs without errors #366 merged --> doesn't have any effect really ... it's only for being able to properly build the 0.1 docs after checking out git checkout maint/0.1 and calling make build-doc

  2. get MRG: first step DOC versioning #364 merged ... this contains minor fixes of the current docs and a small enhancement --> previously users could only select between DEV and STABLE docs from the main page ... with that PR they'll be able to do that from all pages.

  3. Change the way we handle docs:

  4. Finally, with our stable docs getting their own X.Y directory on gh-pages and dev docs being deployed their continuously, we can add the links for old versions to the version selection dropdown menu that is introduced in step 2 with MRG: first step DOC versioning #364

  5. profit 😄

final note: the binder links at the end of each sphinx gallery example will always resolve to the stable docs version. --> that's because the binder feature is still "experimental" and there are not a lot of customization options. ... not true, see #370


What do you think? @mne-tools/mne-bids

@agramfort
Copy link
Member

agramfort commented Mar 22, 2020 via email

@jasmainak
Copy link
Member

okay just so I understand:

  • this amounts to an additional step during the release process? could this be documented or automated in the Makefile?
  • the binder links will not work for the older versions?

how much future maintenance work does this entail for me? :P I'm getting lazy these days ...

@sappelhoff
Copy link
Member Author

this amounts to an additional step during the release process?

yes, it's not a lot of work though, because the maintainer who releases is expected to build and inspect the docs manually anyways. The additional step is copying the doc/_build/html directory and pushing it to gh-pages

could this be documented or automated in the Makefile?

could be automated, but for now I would simply document this in the Wiki where we write down the release process

the binder links will not work for the older versions?

no ... they will always redirect to STABLE. --> aaand if there is an example in 0.X that we killed in 0.X+1 (deleted/removed) then there'll be a 404.

But that's something that could be improved in the future, when more people start using binder with sphinx gallery

how much future maintenance work does this entail for me? :P I'm getting lazy these days ...

given the (unlikely/unreasonable) assumption that I won't be around: estimated 3 minutes every 6 months :-D ... else: 0 minutes

This was referenced Mar 24, 2020
@sappelhoff
Copy link
Member Author

closed with #370 and #371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants