Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move installer menus from mne-feedstock to this repo #100

Closed
hoechenberger opened this issue Mar 20, 2022 · 7 comments
Closed

Move installer menus from mne-feedstock to this repo #100

hoechenberger opened this issue Mar 20, 2022 · 7 comments
Labels

Comments

@hoechenberger
Copy link
Member

Once conda/constructor#500 has been merged, we may be able to get rid of the mne-installer-menus conda-forge package and instead move all the menu-related files to this repo and simply configure the installer to place those files in the correct location before menuinst is being run. This would allow us to test & release changes to the menus without tagging a new mne-base, mne, and mne-installer-menus release everytime!

@hoechenberger hoechenberger changed the title Move installer menues from mne-feedstock to this repo Move installer menus from mne-feedstock to this repo Mar 20, 2022
@larsoner
Copy link
Member

larsoner commented Oct 7, 2022

@hoechenberger do you want to give this a try now?

@hoechenberger
Copy link
Member Author

hoechenberger commented Oct 7, 2022

Let's not touch this for now and instead wait until we can completely abandon the napari forks we currently use to build our installers. Once we're back on vanilla, we can start looking into this issue here again. Agreed?

@larsoner
Copy link
Member

larsoner commented Oct 7, 2022

Yeah that makes sense! EDIT: Issue is #131

@larsoner
Copy link
Member

larsoner commented Sep 1, 2023

@hoechenberger it would be good to tackle this once #195 lands. Do you know the changes that need to be made or can you point me to an example? I could look into this next

@larsoner
Copy link
Member

larsoner commented Sep 1, 2023

I guess it would mean just moving mne-feedstock/recipe/menu to mne-installers/assets/menu, renaming menu/menu.json to menu/mne.json (I think?) then adding menu/* to extra_files config value. But this requires menuinst to be run after the extra_files are copied. I guess it's worth a shot...

@hoechenberger
Copy link
Member Author

Yes I totally lost track of when menuinst is now running :(

@larsoner
Copy link
Member

Based on how menu_packages config var works I think we're using things the intended way so I'll close. But @hoechenberger if you think it is possible to move to the recipe let's reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants