You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We had to disable the test for sorted outputs, because:
It was never previously exercised on a block version where the sorted output requirement is active
It turns out the test tx only have one TxOut in it, so it is sorted for trivial reasons even when the reverse sorter is installed. This causes the test for sorting check effectiveness to pass even though the test expects it to fail.
I think we can fix this test if we go into the get_transaction function in mc_transaction_core_test_utils and make it add a second output, e.g. a change output, because then I think the test will work as intended
(Maybe worth capturing in a testing fast-follow-on ticket?
We had to disable the test for sorted outputs, because:
I think we can fix this test if we go into the
get_transaction
function inmc_transaction_core_test_utils
and make it add a second output, e.g. a change output, because then I think the test will work as intended(Maybe worth capturing in a testing fast-follow-on ticket?
Originally posted by @sugargoat in #1827 (comment))
The text was updated successfully, but these errors were encountered: