You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When developing a plugin that listens to ClientConfig_ConfigChange, inside a multi-context-aware setup, there is no way of knowing which context just got changed/updated.
Step to reproduce
Inside a plugin try to get the settings to the currently changed context:
// This always returns `mgr`, which sort of is correct:$contextKey = $modx->contextinstanceof modContext || $modx->contextinstanceof \MODX\Revolution\modContext ? $modx->context->get('key') : 'web';
$settings = $clientConfig->getSettings($contextKey);
Observed/Expected behavior
There is currently no way to know which context got changed. When the event is invoked, it would be beneficial to also send the context-key of the currently changed context.
Environment
ClientConfig 2.3.3-pl
MODX Revolution 2.8.5-pl
The text was updated successfully, but these errors were encountered:
Summary
When developing a plugin that listens to
ClientConfig_ConfigChange
, inside a multi-context-aware setup, there is no way of knowing which context just got changed/updated.Step to reproduce
Inside a plugin try to get the settings to the currently changed context:
Observed/Expected behavior
There is currently no way to know which context got changed. When the event is invoked, it would be beneficial to also send the context-key of the currently changed context.
Environment
ClientConfig 2.3.3-pl
MODX Revolution 2.8.5-pl
The text was updated successfully, but these errors were encountered: