Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't preview locked resources #11

Open
Mark-H opened this issue Dec 20, 2018 · 2 comments
Open

Can't preview locked resources #11

Mark-H opened this issue Dec 20, 2018 · 2 comments

Comments

@Mark-H
Copy link
Member

Mark-H commented Dec 20, 2018

Pops up a notice that the resource is locked.

@sebastian-marinescu
Copy link
Contributor

As a user needs to have the magic show_preview key anyway to see the resource, can't we just unlock the magic resource here: https://github.com/modmore/MagicPreview/blob/master/core/components/magicpreview/elements/plugins/magicpreview.plugin.php#L38 ?

@Mark-H
Copy link
Member Author

Mark-H commented Dec 20, 2018

Not quite - the lock is interfering in the resource/preview processor that prepares the value. The preview isn't stored, so it's not getting to checking the show_preview in the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants