Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FontAwesome? #26

Open
jpdevries opened this issue Jul 13, 2015 · 3 comments
Open

Remove FontAwesome? #26

jpdevries opened this issue Jul 13, 2015 · 3 comments
Labels
Milestone

Comments

@jpdevries
Copy link
Contributor

jpdevries commented Jul 13, 2015

Now that modmore doesn't support MODX 2.2 and 2.3 ships with FontAwesome, should we remove FontAwesome?


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Mark-H
Copy link
Member

Mark-H commented Jul 13, 2015

I don't think we should be actively breaking compatibility, but when we reach a next minor and 2.2 support is "holding us back" I think it makes sense to remove it if it means we can simplify some code.

@jpdevries
Copy link
Contributor Author

curious if maybe we should only load it for pre 2.3 then (like we do with other assets in Redactor). Currently it "double loads" in 2.3

@Mark-H
Copy link
Member

Mark-H commented Mar 7, 2016

Given the icons selection is based on the css file, I'm not sure we should get rid of it just yet. We're also using a different prefix (the standard fa instead of icon in MODX), so for now let's just leave it in.

Might be a good one for QSB 2. Or MODX 3. Which ever comes first.

@Mark-H Mark-H modified the milestone: 2.0 Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants