Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use btn-outline-secondary in place of btn-secondary-outline #94

Open
cadu-leite opened this issue Mar 16, 2018 · 1 comment
Open

use btn-outline-secondary in place of btn-secondary-outline #94

cadu-leite opened this issue Mar 16, 2018 · 1 comment

Comments

@cadu-leite
Copy link

it is btn-outline-secondary and not btn-secondary-outline

the class name for outlined buttons is btn-outline-secondary
like in bootstrap samples page

<div class="input-group mb-3">
  <div class="input-group-prepend">
    <button class="btn btn-outline-secondary" type="button">Button</button>
  </div>
  <input type="text" class="form-control" placeholder="" aria-label="" aria-describedby="basic-addon1">
</div>

see at https://getbootstrap.com/docs/4.0/components/input-group/#button-addons

and not as used in Modular-admin sample site.

<button type="button" class="btn btn-secondary-outline">Secondary</button>
@m10241
Copy link

m10241 commented May 18, 2018

Thanks for your comment. I think both of them are correct and the class name that you mentioned is the customized version of bootstrap. It has the styling that matches modularadmin. You can use either btn-secondary-outline to have modularadmin styling or btn-outline-secondary to have bootstrap default styling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants