add system setting for error.log which defaults to 'logs/' and uses this configurable path for logging #12352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't tested this yet - but what would happen if you cannot connect to the database? Where would the error log? |
| @@ -10,7 +10,8 @@ public function checkPermissions() { | |||
| return $this->modx->hasPermission('error_log_erase'); | |||
| } | |||
| public function process() { | |||
| $file = $this->modx->getOption(xPDO::OPT_CACHE_PATH).'logs/error.log'; | |||
| $error_log_path = $this->modx->getOption('error_log_path'); | |||
| $file = MODX_BASE_PATH.$error_log_path.'error.log'; | |||
There was a problem hiding this comment.
This should be an absolute path, eg /home/website.tld/core/error.log
|
Closing due to long inactivity. Feel free to reopen with more details and rebased to 2.x branch |
|
I am looking for that option too. What is the problem to implement this? I am logging to another path with a snippet and want too see the logs at the modx error log page. |
|
This was closed as the contributor did not respond to questions about the implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
worked on this at modx ccc 2015.
i hope it does not break anything.
any feedback is appreciated.
modx-ccc-2015/whishlist#39