Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'request' package in bulk-api adapter with 'axios' as request is deprecated #4018

Open
11 tasks
elnyry-sam-k opened this issue Nov 25, 2024 · 0 comments
Open
11 tasks
Assignees
Labels
oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story

Comments

@elnyry-sam-k
Copy link
Member

Goal:

As a maintainer of Mojaloop OSS

I want to ensure packages and libraries used in the bulk-api-adapter service (Mojaloop OSS components) are well maintained

so that Mojaloop services make use of the available feature set and have no known security vulnerabilities (medium or high)

Acceptance Criteria:

  • "Request" package is replaced in the Mojaloop repo bulk-api-adapter

Complexity: Medium

Uncertainty:Medium

Notes:


Tasks:

  • Finalize axios as replacement for request
  • Refactor bulk-api-adapter service to use axios in the place of 'request'
  • Ensure all tests and functionality work same as before
  • PR and release

Done

  • Acceptance Criteria pass
  • Unit Tests pass
  • Integration Tests pass
  • Code Style & Coverage meets standards
  • Changes made to config (default.json) are broadcast to team and follow-up tasks added to update helm charts and other deployment config.

Pull Requests:

  • TBD

Follow-up:

  • N/A

Dependencies:

  • N/A

Accountability:

  • Owner: TBC
  • QA/Review: TBC
@elnyry-sam-k elnyry-sam-k added story oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it labels Nov 25, 2024
@elnyry-sam-k elnyry-sam-k changed the title Replace 'request' package in bulk-api adapter to 'axios' as request is deprecated Replace 'request' package in bulk-api adapter with 'axios' as request is deprecated Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oss-core This is an issue - story or epic related to a feature on a Mojaloop core service or related to it story
Projects
None yet
Development

No branches or pull requests

2 participants