Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete check for minimum population of macrostates #4

Open
biofe opened this issue Oct 1, 2024 · 0 comments
Open

Incomplete check for minimum population of macrostates #4

biofe opened this issue Oct 1, 2024 · 0 comments

Comments

@biofe
Copy link

biofe commented Oct 1, 2024 •
edited
Loading

In process_mpp.py in line 658 (if pops[state_i] > pop_thr and qmin > qmin_thr:), only the population of one branch is tested. This may lead to macrostates (state_j) with a population below pop_thr. The fix is as simple as if pops[state_i] > pop_thr and pops[state_j] > pop_thr and qmin > qmin_thr:.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@biofe