From a6a9a1ae9ad5c55e05871b85fe0b8ea89f61ecee Mon Sep 17 00:00:00 2001 From: carmenmaymo Date: Mon, 29 Apr 2024 12:07:55 +0200 Subject: [PATCH 1/3] Change apple validation error string PIWOO-227 --- src/Buttons/ApplePayButton/ApplePayDirectHandler.php | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/Buttons/ApplePayButton/ApplePayDirectHandler.php b/src/Buttons/ApplePayButton/ApplePayDirectHandler.php index 1d8b6326..0ac3a409 100644 --- a/src/Buttons/ApplePayButton/ApplePayDirectHandler.php +++ b/src/Buttons/ApplePayButton/ApplePayDirectHandler.php @@ -53,14 +53,12 @@ public function bootstrap($buttonEnabledProduct, $buttonEnabledCart) } if (!$this->merchantValidated()) { - /* translators: Placeholder 1: Opening strong tag. Placeholder 2: Closing strong tag. Placeholder 3: Opening link tag to documentation. Placeholder 4: Closing link tag.*/ + /* translators: Placeholder 1: Opening link tag to documentation. Placeholder 2: Closing link tag.*/ $message = sprintf( - esc_html__( - '%1$sApple Pay Validation Error%2$s Check %3$sApple Server requirements page%4$s to fix it in order to make the Apple Pay button work', - 'mollie-payments-for-woocommerce' - ), - '', - '', + esc_html__( + 'Apple Pay Validation Error: Please review the %1$sApple Server requirements%2$s. If everything appears correct, click the Apple Pay button to retry validation.', + 'mollie-payments-for-woocommerce' + ), '', '' ); From 02ffdac097c813c3f9545596eaf9a15a3464354d Mon Sep 17 00:00:00 2001 From: carmenmaymo Date: Mon, 29 Apr 2024 12:14:20 +0200 Subject: [PATCH 2/3] Fix phpcs PIWOO-227 --- src/Buttons/ApplePayButton/ApplePayDirectHandler.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Buttons/ApplePayButton/ApplePayDirectHandler.php b/src/Buttons/ApplePayButton/ApplePayDirectHandler.php index 0ac3a409..59a6a86b 100644 --- a/src/Buttons/ApplePayButton/ApplePayDirectHandler.php +++ b/src/Buttons/ApplePayButton/ApplePayDirectHandler.php @@ -55,10 +55,10 @@ public function bootstrap($buttonEnabledProduct, $buttonEnabledCart) if (!$this->merchantValidated()) { /* translators: Placeholder 1: Opening link tag to documentation. Placeholder 2: Closing link tag.*/ $message = sprintf( - esc_html__( - 'Apple Pay Validation Error: Please review the %1$sApple Server requirements%2$s. If everything appears correct, click the Apple Pay button to retry validation.', - 'mollie-payments-for-woocommerce' - ), + esc_html__( + 'Apple Pay Validation Error: Please review the %1$sApple Server requirements%2$s. If everything appears correct, click the Apple Pay button to retry validation.', + 'mollie-payments-for-woocommerce' + ), '', '' ); From a233c6bf2a86b51a20a56e065c327d2a06bd54ca Mon Sep 17 00:00:00 2001 From: carmenmaymo Date: Mon, 6 May 2024 16:36:28 +0200 Subject: [PATCH 3/3] Open link in new window --- src/Buttons/ApplePayButton/ApplePayDirectHandler.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Buttons/ApplePayButton/ApplePayDirectHandler.php b/src/Buttons/ApplePayButton/ApplePayDirectHandler.php index 59a6a86b..bf80e8bb 100644 --- a/src/Buttons/ApplePayButton/ApplePayDirectHandler.php +++ b/src/Buttons/ApplePayButton/ApplePayDirectHandler.php @@ -59,7 +59,7 @@ public function bootstrap($buttonEnabledProduct, $buttonEnabledCart) 'Apple Pay Validation Error: Please review the %1$sApple Server requirements%2$s. If everything appears correct, click the Apple Pay button to retry validation.', 'mollie-payments-for-woocommerce' ), - '', + '', '' );