Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subject_taxon and object_taxon parameters to associations endpoint #546

Closed
kevinschaper opened this issue Jan 22, 2024 · 1 comment · Fixed by #548
Closed

Add subject_taxon and object_taxon parameters to associations endpoint #546

kevinschaper opened this issue Jan 22, 2024 · 1 comment · Fixed by #548
Assignees
@glass-ships
Labels
api
Milestone
2024-02 Release

Comments

@kevinschaper
Copy link
Member

It's not currently possible to constrain association queries by the taxon of the subject or object, we should add subject_taxon & object_taxon params to the associations endpoint.

This issue is inspired by the queries against the biolink API shown in this issue: biothings/biothings_explorer#774
@kevinschaper kevinschaper added this to the 2024-02 Release milestone Jan 22, 2024
@kevinschaper
Copy link
Member Author

While we're in there, we should add subject_category, object_category, subject_namespace, object_namespace as well.

@kevinschaper kevinschaper mentioned this issue Jan 22, 2024
Closed
@glass-ships glass-ships mentioned this issue Jan 22, 2024
Merged
kevinschaper added a commit that referenced this issue Jan 29, 2024
@glass-ships @kevinschaper
add subj/obj taxon, category, namespace to assoc api endpoint (#548)
dfe720c 
Closes #546 

- Adds some extra parameters to associations endpoint and
SolrImplementation.get_associations
- Adds api tests for proper parameters being passed to SI
- Small fix to TextAnnotator
- Update to SI's Query model methods for adding facet fields

---------

Co-authored-by: Kevin Schaper <[email protected]>
@colleenXu colleenXu mentioned this issue Feb 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glass-ships glass-ships

Labels
api
Projects
None yet
Milestone
2024-02 Release
Development

Successfully merging a pull request may close this issue.

add subj/obj taxon, category, namespace to assoc api endpoint monarch-initiative/monarch-app
2 participants
@kevinschaper @glass-ships